ENH: Give Error message when no conda env is present #120
Conversation
…tion is not installed
| if [[ -z "$CONDA_PREFIX" ]]; then | ||
| echo -e "${RED}Error: No Conda environment is active. Please activate a conda env with MPI installed.${NC}" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
What if the user has global installation of MPI implementation?
There was a problem hiding this comment.
This condition might cause false negative.
| echo -e "${RED}Error: mpiexec not found. Please install MPI (OpenMPI or MPICH) via Conda or system package manager.${NC}" | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Checking for existence of ${CONDA_PREFIX}/bin/mpiexec doesn't detect MPI compilers, include paths, or libraries. We are only checking for runtime control here.
The correct approach probably will be to eventually use cmake build system for us. We've an open issue for this: #19
The current approach isn't the best one though.
There was a problem hiding this comment.
I checked pFUnit repository, the way they check the existence of MPI is using cmake's find_package using:
find_package (MPI QUIET COMPONENTS Fortran)
if (MPI_Fortran_FOUND)
message (STATUS "MPI enabled")
if (ENABLE_MPI_F08)
if (NOT MPI_Fortran_HAVE_F08_MODULE)
message (FATAL_ERROR "MPI F08 module requested but not available")
else()
message (STATUS "MPI F08 module enabled")
endif()
endif()
else ()
message (STATUS "MPI not found; building without MPI")
endif()There was a problem hiding this comment.
Ohh YEs i Didn't see that CMAKE issue Thanks for mentioning it.
We can avoid this approach if not needed.
This is just small error message as when no conda env is activated then there is no MPI or MPICH is present so user gets confused on what to do (Also we observed on call too).
(This also can be avoided I felt it to be included that's why :)
Earlier case
With this PR